personal-finance/budget
2
1
Fork 0
Code Issues 11 Pull Requests Projects 6 Releases 2 Wiki Activity

[Fix] Improves logging for bank/creditcard parser

Browse Source 
When the credit card was correct but the bank was wrong, it was
difficul to accertain which one was wrong. Not when one fails, it will
also log what are the available options.
This commit is contained in:
Luís Murta 2022-11-22 22:09:40 +00:00
parent 9345530f06
commit 5f2cb6fcf5
Signed by: satprog
GPG Key ID: 169EF1BBD7049F94
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
pfbudget/input/parsers.py
View File

@ -4,7 +4,7 @@ from importlib import import_module
import datetime as dt import datetime as dt
import yaml import yaml
from pfbudget.common.types import Transaction from pfbudget.common.types import NoBankSelected, Transaction, Transactions
from pfbudget.utils import utils from pfbudget.utils import utils
Index = namedtuple( Index = namedtuple(
@ -43,7 +43,7 @@ Options = namedtuple(
) )
def parse_data(filename: str, args: dict) -> None: def parse_data(filename: str, args: dict) -> Transactions:
cfg: dict = yaml.safe_load(open("parsers.yaml")) cfg: dict = yaml.safe_load(open("parsers.yaml"))
assert ( assert (
"Banks" in cfg "Banks" in cfg
@ -57,17 +57,25 @@ def parse_data(filename: str, args: dict) -> None:
bank = args["bank"][0] bank = args["bank"][0]
creditcard = None if not args["creditcard"] else args["creditcard"][0] creditcard = None if not args["creditcard"] else args["creditcard"][0]
if not creditcard: try:
options: dict = cfg[bank] options: dict = cfg[bank]
else: except KeyError as e:
options: dict = cfg[bank][creditcard] banks = cfg["Banks"]
raise NoBankSelected(f"{e} not a valid bank, try one of {banks}")
if creditcard:
try:
options = options[creditcard]
except KeyError as e:
creditcards = cfg["CreditCards"]
raise NoBankSelected(f"{e} not a valid bank, try one of {creditcards}")
bank += creditcard bank += creditcard
if args["category"]: if args["category"]:
options["category"] = args["category"][0] options["category"] = args["category"][0]
if options.get("additional_parser"): if options.get("additional_parser"):
parser = getattr(import_module("pfbudget.parsers"), bank) parser = getattr(import_module("pfbudget.input.parsers"), bank)
transactions = parser(filename, bank, options).parse() transactions = parser(filename, bank, options).parse()
else: else:
transactions = Parser(filename, bank, options).parse() transactions = Parser(filename, bank, options).parse()