From 18fc469637151dfee55bfb8d09d1ede08400c19a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lu=C3=ADs=20Murta?= <luis@murta.dev>
Date: Sat, 18 May 2024 23:21:24 +0100
Subject: [PATCH] API: fix no banks/transactions status code

No content on the GET response from the banks/tarnsactions methods
should be a 204.
---
 docs/openapi.yaml          |  4 ++--
 internal/api/server.gen.go | 30 +++++++++++++++---------------
 internal/dal/impl_test.go  |  6 +++---
 3 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/docs/openapi.yaml b/docs/openapi.yaml
index edfa1ad..d617f52 100644
--- a/docs/openapi.yaml
+++ b/docs/openapi.yaml
@@ -54,7 +54,7 @@ paths:
             application/json:
               schema:
                 $ref: "#/components/schemas/Transactions"
-        "404":
+        "204":
           description: No transactions
 
   /transaction/{transactionId}:
@@ -92,7 +92,7 @@ paths:
             application/json:
               schema:
                 $ref: "#/components/schemas/Banks"
-        "404":
+        "204":
           description: No banks
 
   /bank/{bankId}:
diff --git a/internal/api/server.gen.go b/internal/api/server.gen.go
index 352c357..fce6fe4 100644
--- a/internal/api/server.gen.go
+++ b/internal/api/server.gen.go
@@ -205,21 +205,21 @@ func RegisterHandlersWithBaseURL(router EchoRouter, si ServerInterface, baseURL
 // Base64 encoded, gzipped, json marshaled Swagger object
 var swaggerSpec = []string{
 
-	"H4sIAAAAAAAC/8xWTY/bNhD9KwTbo1bSxosedGqDRRYGinTRtKc0B1oayUz4oZBDu4bh/14MpbX1tfEW",
-	"aBe5eCVxOG/em8fhHnlpdWsNGPS8OHJfbkGL+PhWmC/0t3W2BYcS4ldZ0S8eWuAF9+ikafgp4UZoWF6w",
-	"rpINmHXcV1unBfKChyArnkzDTwl38DVIBxUvPvIYEjN/OofazWcokTJTfV1JCDo+/Oig5gX/IbtwynpC",
-	"WWRzOqcRzokDvf/hhPGiRGnNnGwpEBrrDovMKoEw4hQ/JAuB4Esn2yeI2bocSyMN/nTHE66lkTpoXuTn",
-	"nNIgNOBo006oMIavlRV4wTdBbyh0SdO+0mFhTxmXlB5o9HLBh8LOdKeqpKltFNkaFCXSI2ghFVGRRpgS",
-	"ftbBoUgr2M1k5I/gvDVCsXddLPsAbgfuL2KiZAnGR3U6X/KH93+yBzDghGKPYaNkyX7tgthulebMOqYE",
-	"guMJD44q2CK2vsiy/X6fNiak1jVZn9ZnTatuVml+41GYSihrIN2iVpGmRAVL5d2w31owvzyu2SrNSW1w",
-	"vmOSp3l6S3ttC0a0khd8lebpiie8FbiNQmcbYb5kR/pdVyf60kBUjNwqSBI6X/wBkHz+9rCu4m4nNCA4",
-	"z4uPx4l+63tma0YJGVrmAIMj6SStEezTySt4B8qHNkIXIOlnxaJ3p349faLtvrWkH+14k+dPvQcTmYi2",
-	"VbKMXLLPvjsqF4TrR/s0s8iHUJbgfR0UO8tEOt912BM9zE4oWbH1PfOBSoGqi72bxxIgMxZZbYOp4hHz",
-	"QWtBg4K/k6bqdN0c2Po+rsb2+Wtt8/x/Fsn/O5UWmL+3bNMnGnL+HdBJ2AGDv6VHaZpBVIaXQZAdBy9X",
-	"jDyYHy/38yD9NVuPKvmO3T2ao69o8gHut70+1HxgeZxcGi/os7/W5FoqBEcoQ9DzLd33+WuA+NI3erB8",
-	"UdwEpcSGRnXX7dk/IlPo7jqdeMzPTTYBV1JLHCFXUIugkBe3eZ6MvLV6c+XWn1dl69oDstpZzfZbcNAX",
-	"1J1GHEu7VF+XYLnAm9uF+q7X1J/ELcQh8Axuv3RBvdqAWoKqGG2n/u+3stwSWW8dPoPRLz2P8UrH9j8Z",
-	"uzjO9+3pOwk+nf4JAAD//62NJ7znCwAA",
+	"H4sIAAAAAAAC/8xWTY/bNhD9KwTbo1bSrhc96NQGiywMFOmiaU9pDrQ0kpnwQyGHdg3D/70YSmvra+Mt",
+	"0Aa5eCVxOG/em8fhHnlpdWsNGPS8OHJfbkGL+PhGmM/0t3W2BYcS4ldZ0S8eWuAF9+ikafgp4UZoWF6w",
+	"rpINmHXcV1unBfKChyArnkzDTwl38CVIBxUvPvAYEjN/PIfazScokTJTfV1JCDo+/Oig5gX/IbtwynpC",
+	"WWRzOqcRzokDvf/hhPGiRGnNnGwpEBrrDovMKoEw4hQ/JAuB4Esn22eI2bocSyMN/nTPE66lkTpoXuTn",
+	"nNIgNOBo006oMIavlRV4wTdBbyh0SdO+0mFhzxmXlB5o9HrBh8LOdKeqpKltFNkaFCXSI2ghFVGRRpgS",
+	"ftbBoUgr2M1k5E/gvDVCsbddLHsPbgfuL2KiZAnGR3U6X/LHd3+yRzDghGJPYaNkyX7tgthulebMOqYE",
+	"guMJD44q2CK2vsiy/X6fNiak1jVZn9ZnTatuVml+41GYSihrIN2iVpGmRAVL5d2w31owvzyt2SrNSW1w",
+	"vmOSp3l6S3ttC0a0khd8lebpiie8FbiNQmcbYT5nR/pdVyf60kBUjNwqSBI6X/wRkHz+5rCu4m4nNCA4",
+	"z4sPx4l+6wdma0YJGVrmAIMj6SStEezzySt4B8qHNkIXIOlnxaJ3p349faTtvrWkH+24y/Pn3oOJTETb",
+	"KllGLtkn3x2VC8L1o32aWeR9KEvwvg6KnWUine877IkeZieUrNj6gflApUDVxd7PYwmQGYustsFU8Yj5",
+	"oLWgQcHfSlN1um4ObP0QV2P7/LW2ef4/i+T/jUp3S8zfWbbpEw05/w7oJOyAwd/SozTNICrDyyDIjoOX",
+	"K0YezI/X+3mQ/pqtR5V8x+4ezdFvaPIB7te9PtR8YHmcXBqv6LO/1uRaKgRHKEPQ8y3d9/lLgPjSN3qw",
+	"fFHcBKXEhkZ11+3ZPyJT6O46nXjMz002AVdSSxwhV1CLoJAXt3mejLy1urty68+rsnXtAVntrGb7LTjo",
+	"C+pOI46lXaqvS7Bc4M3tQn3Xa+pP4hbiEHgBt1+6oF5tQC1BVYy2U//3W1luiay3Dl/A6JdexvhGx/Y/",
+	"Gbs4zvf16TsJPp3+CQAA///puNwi5wsAAA==",
 }
 
 // GetSwagger returns the content of the embedded swagger specification file
diff --git a/internal/dal/impl_test.go b/internal/dal/impl_test.go
index 2b012e8..55d8b9d 100644
--- a/internal/dal/impl_test.go
+++ b/internal/dal/impl_test.go
@@ -94,9 +94,8 @@ func TestDalImpl_Transactions(t *testing.T) {
 		want    entity.Transactions
 		wantErr bool
 	}{
-		{"empty", fields{db}, args{}, nil, false},
 		{
-			"without category",
+			"200",
 			fields{db},
 			args{[][]driver.Value{
 				{1, date, "income", 1000},
@@ -108,6 +107,7 @@ func TestDalImpl_Transactions(t *testing.T) {
 			},
 			false,
 		},
+		{"204", fields{db}, args{}, nil, false},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
@@ -201,7 +201,7 @@ func TestDalImpl_Banks(t *testing.T) {
 			},
 			false,
 		},
-		{"404", fields{db}, args{}, nil, false},
+		{"204", fields{db}, args{}, nil, false},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {