personal-finance/datastore
2
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Releases Wiki Activity

API: fix no banks/transactions status code

Browse Source 
No content on the GET response from the banks/tarnsactions methods
should be a 204.
This commit is contained in:
Luís Murta 2024-05-18 23:21:24 +01:00
parent c464247112
commit 18fc469637
Signed by: satprog
GPG Key ID: 169EF1BBD7049F94
3 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/openapi.yaml
View File

@ -54,7 +54,7 @@ paths:
application/json: application/json:
schema: schema:
$ref: "#/components/schemas/Transactions" $ref: "#/components/schemas/Transactions"
"404": "204":
description: No transactions description: No transactions
/transaction/{transactionId}: /transaction/{transactionId}:
@ -92,7 +92,7 @@ paths:
application/json: application/json:
schema: schema:
$ref: "#/components/schemas/Banks" $ref: "#/components/schemas/Banks"
"404": "204":
description: No banks description: No banks
/bank/{bankId}: /bank/{bankId}:

30
internal/api/server.gen.go
View File

@ -205,21 +205,21 @@ func RegisterHandlersWithBaseURL(router EchoRouter, si ServerInterface, baseURL
// Base64 encoded, gzipped, json marshaled Swagger object // Base64 encoded, gzipped, json marshaled Swagger object
var swaggerSpec = []string{ var swaggerSpec = []string{
"H4sIAAAAAAAC/8xWTY/bNhD9KwTbo1bSxosedGqDRRYGinTRtKc0B1oayUz4oZBDu4bh/14MpbX1tfEW", "H4sIAAAAAAAC/8xWTY/bNhD9KwTbo1bSrhc96NQGiywMFOmiaU9pDrQ0kpnwQyGHdg3D/70YSmvra+Mt",
"aBe5eCVxOG/em8fhHnlpdWsNGPS8OHJfbkGL+PhWmC/0t3W2BYcS4ldZ0S8eWuAF9+ikafgp4UZoWF6w", "0Aa5eCVxOG/em8fhHnlpdWsNGPS8OHJfbkGL+PhGmM/0t3W2BYcS4ldZ0S8eWuAF9+ikafgp4UZoWF6w",
"rpINmHXcV1unBfKChyArnkzDTwl38DVIBxUvPvIYEjN/OofazWcokTJTfV1JCDo+/Oig5gX/IbtwynpC", "rpINmHXcV1unBfKChyArnkzDTwl38CVIBxUvPvAYEjN/PIfazScokTJTfV1JCDo+/Oig5gX/IbtwynpC",
"WWRzOqcRzokDvf/hhPGiRGnNnGwpEBrrDovMKoEw4hQ/JAuB4Esn2yeI2bocSyMN/nTHE66lkTpoXuTn", "WWRzOqcRzokDvf/hhPGiRGnNnGwpEBrrDovMKoEw4hQ/JAuB4Esn22eI2bocSyMN/nTPE66lkTpoXuTn",
"nNIgNOBo006oMIavlRV4wTdBbyh0SdO+0mFhTxmXlB5o9HLBh8LOdKeqpKltFNkaFCXSI2ghFVGRRpgS", "nNIgNOBo006oMIavlRV4wTdBbyh0SdO+0mFhzxmXlB5o9HrBh8LOdKeqpKltFNkaFCXSI2ghFVGRRpgS",
"ftbBoUgr2M1k5I/gvDVCsXddLPsAbgfuL2KiZAnGR3U6X/KH93+yBzDghGKPYaNkyX7tgthulebMOqYE", "ftbBoUgr2M1k5E/gvDVCsbddLHsPbgfuL2KiZAnGR3U6X/LHd3+yRzDghGJPYaNkyX7tgthulebMOqYE",
"guMJD44q2CK2vsiy/X6fNiak1jVZn9ZnTatuVml+41GYSihrIN2iVpGmRAVL5d2w31owvzyu2SrNSW1w", "guMJD44q2CK2vsiy/X6fNiak1jVZn9ZnTatuVml+41GYSihrIN2iVpGmRAVL5d2w31owvzyt2SrNSW1w",
"vmOSp3l6S3ttC0a0khd8lebpiie8FbiNQmcbYb5kR/pdVyf60kBUjNwqSBI6X/wBkHz+9rCu4m4nNCA4", "vmOSp3l6S3ttC0a0khd8lebpiie8FbiNQmcbYT5nR/pdVyf60kBUjNwqSBI6X/wRkHz+5rCu4m4nNCA4",
"z4uPx4l+63tma0YJGVrmAIMj6SStEezTySt4B8qHNkIXIOlnxaJ3p349faLtvrWkH+14k+dPvQcTmYi2", "z4sPx4l+6wdma0YJGVrmAIMj6SStEezzySt4B8qHNkIXIOlnxaJ3p349faTtvrWkH+24y/Pn3oOJTETb",
"VbKMXLLPvjsqF4TrR/s0s8iHUJbgfR0UO8tEOt912BM9zE4oWbH1PfOBSoGqi72bxxIgMxZZbYOp4hHz", "KllGLtkn3x2VC8L1o32aWeR9KEvwvg6KnWUine877IkeZieUrNj6gflApUDVxd7PYwmQGYustsFU8Yj5",
"QWtBg4K/k6bqdN0c2Po+rsb2+Wtt8/x/Fsn/O5UWmL+3bNMnGnL+HdBJ2AGDv6VHaZpBVIaXQZAdBy9X", "oLWgQcHfSlN1um4ObP0QV2P7/LW2ef4/i+T/jUp3S8zfWbbpEw05/w7oJOyAwd/SozTNICrDyyDIjoOX",
"jDyYHy/38yD9NVuPKvmO3T2ao69o8gHut70+1HxgeZxcGi/os7/W5FoqBEcoQ9DzLd33+WuA+NI3erB8", "K0YezI/X+3mQ/pqtR5V8x+4ezdFvaPIB7te9PtR8YHmcXBqv6LO/1uRaKgRHKEPQ8y3d9/lLgPjSN3qw",
"UdwEpcSGRnXX7dk/IlPo7jqdeMzPTTYBV1JLHCFXUIugkBe3eZ6MvLV6c+XWn1dl69oDstpZzfZbcNAX", "fFHcBKXEhkZ11+3ZPyJT6O46nXjMz002AVdSSxwhV1CLoJAXt3mejLy1urty68+rsnXtAVntrGb7LTjo",
"1J1GHEu7VF+XYLnAm9uF+q7X1J/ELcQh8Axuv3RBvdqAWoKqGG2n/u+3stwSWW8dPoPRLz2P8UrH9j8Z", "C+pOI46lXaqvS7Bc4M3tQn3Xa+pP4hbiEHgBt1+6oF5tQC1BVYy2U//3W1luiay3Dl/A6JdexvhGx/Y/",
"uzjO9+3pOwk+nf4JAAD//62NJ7znCwAA", "Gbs4zvf16TsJPp3+CQAA///puNwi5wsAAA==",
} }
// GetSwagger returns the content of the embedded swagger specification file // GetSwagger returns the content of the embedded swagger specification file

6
internal/dal/impl_test.go
View File

@ -94,9 +94,8 @@ func TestDalImpl_Transactions(t *testing.T) {
want entity.Transactions want entity.Transactions
wantErr bool wantErr bool
}{ }{
{"empty", fields{db}, args{}, nil, false},
{ {
"without category", "200",
fields{db}, fields{db},
args{[][]driver.Value{ args{[][]driver.Value{
{1, date, "income", 1000}, {1, date, "income", 1000},
@ -108,6 +107,7 @@ func TestDalImpl_Transactions(t *testing.T) {
}, },
false, false,
}, },
{"204", fields{db}, args{}, nil, false},
} }
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
@ -201,7 +201,7 @@ func TestDalImpl_Banks(t *testing.T) {
}, },
false, false,
}, },
{"404", fields{db}, args{}, nil, false}, {"204", fields{db}, args{}, nil, false},
} }
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {