Fix resources naming scheme #25

satprog · 2024-06-22T21:38:13Z

satprog commented

2024-06-22 21:38:13 +00:00

The accepted practice is to retain the collection name even for a single
resource operation, like getting a specific transaction.

Also moves the PUT /transactions to /transactions/{id} which makes it
clearer that it can only be applied to an already created transaction.

The accepted practice is to retain the collection name even for a single resource operation, like getting a specific transaction. Also moves the PUT /transactions to /transactions/{id} which makes it clearer that it can only be applied to an already created transaction.

satprog added this to the /transactions milestone 2024-06-22 21:38:13 +00:00

satprog added the

bug

label 2024-06-22 21:38:13 +00:00

satprog added 3 commits 2024-06-22 21:38:13 +00:00

Implements /transactions POST method 4c82ca0e2b

It adds the method to the OpenAPI spec and generates a new server
config. The requirement for the ID on the Transaction component is
removed, so that it can be reused for insertions.
It also adds two new middlewares, a logging and a spec validator. If a
request does not follow the spec, a 400 is returned immediately.

Issue: #18

Implements /transactions PUT method 55bd87c864

Adds PUT method to OpenAPI spec.

Given that the transaction IDs are generated on server-side, for the PUT
method to remain idempotent, it can only update existing transactions.

It also adds a TransactionExists method on the DAL.

Issue: #20

Fix resources naming scheme 18c93b6c0f

The accepted practice is to retain the collection name even for a single
resource operation, like getting a specific transaction.

Also moves the PUT /transactions to /transactions/{id} which makes it
clearer that it can only be applied to an already created transaction.

satprog added this to the Client-Server architecture project 2024-06-22 21:38:13 +00:00

satprog added a new dependency 2024-06-22 21:38:22 +00:00

#22 Implements /transactions PUT method

satprog requested review from nunorosa 2024-06-22 21:38:29 +00:00

satprog removed this from the Client-Server architecture project 2024-06-22 21:45:39 +00:00

satprog removed this from the /transactions milestone 2024-06-23 19:52:25 +00:00

nunorosa approved these changes 2024-06-25 21:48:24 +00:00

Dismissed

nunorosa left a comment

Nada a dizer aqui! Parece-me fazer tudo sentido, desde a alteração da versão (suspeito que esteja correcto) para a alteração ao alterar o "path" do PUT e a correção dos testes ⭐⭐⭐⭐⭐

satprog referenced this pull request

2024-06-29 10:34:55 +00:00

Implements /transactions PUT method #22

satprog referenced this pull request

2024-06-29 10:35:49 +00:00

Implements /transactions PUT method #22

satprog commented

2024-06-29 11:10:56 +00:00

Nada a dizer aqui! Parece-me fazer tudo sentido, desde a alteração da versão (suspeito que esteja correcto) para a alteração ao alterar o "path" do PUT e a correção dos testes ⭐⭐⭐⭐⭐

A versão é suporto ser semver, e devia ter logo começado em 0.1.0

> Nada a dizer aqui! Parece-me fazer tudo sentido, desde a alteração da versão (suspeito que esteja correcto) para a alteração ao alterar o "path" do PUT e a correção dos testes ⭐⭐⭐⭐⭐ A versão é suporto ser [semver](https://semver.org/), e devia ter logo começado em 0.1.0

nunorosa approved these changes 2024-07-26 10:28:01 +00:00

satprog force-pushed bugfix/resource-naming from 18c93b6c0f to 24b7fc3254

2024-08-03 22:24:44 +00:00

Compare

satprog merged commit 24b7fc3254 into main

2024-08-03 22:25:15 +00:00

satprog deleted branch bugfix/resource-naming

2024-08-03 22:25:15 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Depends on

#22 Implements /transactions PUT method

personal-finance/datastore

Reference: personal-finance/datastore#25