Support modifying a transaction category #32

satprog · 2024-06-23T22:05:35Z

satprog commented

2024-06-23 22:05:35 +00:00

through the PUT /transactions/{transactionId} method.

Restrict the PUT to changing only the category. The other existing
attributes should remain immutable.
Remove the body of the PUT response, it isn't required, and it was
returning a 204, which shouldn't have it.

This patch also extracts the CategoryName as a separate component on the
OpenAPI spec, so that it can be reused on the Transaction.

Issues #26 and #23

through the PUT /transactions/{transactionId} method. Restrict the PUT to changing only the category. The other existing attributes should remain immutable. Remove the body of the PUT response, it isn't required, and it was returning a 204, which shouldn't have it. This patch also extracts the CategoryName as a separate component on the OpenAPI spec, so that it can be reused on the Transaction. Issues #26 and #23

satprog added 5 commits 2024-06-23 22:05:36 +00:00

Implements /transactions POST method 4c82ca0e2b

It adds the method to the OpenAPI spec and generates a new server
config. The requirement for the ID on the Transaction component is
removed, so that it can be reused for insertions.
It also adds two new middlewares, a logging and a spec validator. If a
request does not follow the spec, a 400 is returned immediately.

Issue: #18

Implements /transactions PUT method 55bd87c864

Adds PUT method to OpenAPI spec.

Given that the transaction IDs are generated on server-side, for the PUT
method to remain idempotent, it can only update existing transactions.

It also adds a TransactionExists method on the DAL.

Issue: #20

Fix resources naming scheme 18c93b6c0f

The accepted practice is to retain the collection name even for a single
resource operation, like getting a specific transaction.

Also moves the PUT /transactions to /transactions/{id} which makes it
clearer that it can only be applied to an already created transaction.

Implements GET /categories 9ac249199b

Adds type to OpenAPI. Feature done and tested E2E.
Adds common utilities package named "golang" to overcome language
deficiencies.

Issue #27

Support modifying a transaction category 13d752e69a

through the PUT /transactions/{transactionId} method.

Restrict the PUT to changing only the category. The other existing
attributes should remain immutable.
Remove the body of the PUT response, it isn't required, and it was
returning a 204, which shouldn't have it.

This patch also extracts the CategoryName as a separate component on the
OpenAPI spec, so that it can be reused on the Transaction.

Issues #26 and #23

satprog requested review from nunorosa 2024-06-23 22:05:40 +00:00

satprog force-pushed feature/26-add-category from 13d752e69a to 9e58641001

2024-09-13 18:21:29 +00:00

Compare

satprog added a new dependency 2024-09-13 18:23:24 +00:00

#28 Implements GET /categories

satprog added a new dependency 2024-09-13 18:23:59 +00:00

#33 Return category on /transactions

satprog added 1 commit 2024-09-13 18:35:27 +00:00

Return category on /transactions

Go / build (1.21) (pull_request) Successful in 12s

Details

Go / build (1.22) (pull_request) Successful in 11s

Details

467afae68f

Issue #26

satprog force-pushed feature/26-add-category from 467afae68f to ca692e9aaf

2024-09-13 18:36:44 +00:00

Compare

satprog removed a dependency 2024-09-13 18:37:50 +00:00

#33 Return category on /transactions

satprog force-pushed feature/26-add-category from ca692e9aaf to 50e8269120

2024-09-13 18:40:01 +00:00

Compare

satprog merged commit 50e8269120 into main

2025-03-19 21:36:31 +00:00

satprog deleted branch feature/26-add-category

2025-03-19 21:36:31 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Depends on

#28 Implements GET /categories

personal-finance/datastore

Reference: personal-finance/datastore#32