personal-finance/datastore
2
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Releases Wiki Activity

Return category on /transactions #33

Closed
satprog wants to merge 2 commits from feature/26-get-transaction-category into main
pull from: feature/26-get-transaction-category
merge into: personal-finance:main
Conversation 1 Commits 2 Files Changed 11 +491 -110
satprog commented 2024-06-24 20:46:05 +00:00
Owner
Copy Link

Issue #26

Issue #26
satprog added 6 commits 2024-06-24 20:46:05 +00:00 
It adds the method to the OpenAPI spec and generates a new server
config. The requirement for the ID on the Transaction component is
removed, so that it can be reused for insertions.
It also adds two new middlewares, a logging and a spec validator. If a
request does not follow the spec, a 400 is returned immediately.

Issue: #18
Adds PUT method to OpenAPI spec.

Given that the transaction IDs are generated on server-side, for the PUT
method to remain idempotent, it can only update existing transactions.

It also adds a TransactionExists method on the DAL.

Issue: #20
The accepted practice is to retain the collection name even for a single
resource operation, like getting a specific transaction.

Also moves the PUT /transactions to /transactions/{id} which makes it
clearer that it can only be applied to an already created transaction.
Adds type to OpenAPI. Feature done and tested E2E.
Adds common utilities package named "golang" to overcome language
deficiencies.

Issue #27
through the PUT /transactions/{transactionId} method.

Restrict the PUT to changing only the category. The other existing
attributes should remain immutable.
Remove the body of the PUT response, it isn't required, and it was
returning a 204, which shouldn't have it.

This patch also extracts the CategoryName as a separate component on the
OpenAPI spec, so that it can be reused on the Transaction.

Issues #26 and #23
Issue #26
satprog requested review from nunorosa 2024-06-24 20:46:10 +00:00
satprog force-pushed feature/26-get-transaction-category from 92aa51c664 to 467afae68f 2024-09-13 18:21:50 +00:00 Compare
satprog added a new dependency 2024-09-13 18:23:59 +00:00
#32 Support modifying a transaction category
satprog commented 2024-09-13 18:37:27 +00:00
Author
Owner
Copy Link

The PR will be squashed into the previous one.

The PR will be squashed into the previous one.
satprog removed a dependency 2024-09-13 18:37:50 +00:00
#32 Support modifying a transaction category
satprog closed this pull request 2024-09-13 18:38:09 +00:00
satprog deleted branch feature/26-get-transaction-category 2024-09-13 18:38:33 +00:00
Some checks are pending
Go / build (1.21) (pull_request) Successful in 12s
Details
Go / build (1.22) (pull_request) Successful in 11s
Details
Go / build
Required

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
nunorosa
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
techdebt
Technical debt
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
joanaosoriosousa nunorosa satprog
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: personal-finance/datastore#33
No description provided.
Delete Branch "feature/26-get-transaction-category"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?